WIP: Add NAT support through the use of /advertise(Addr|Port)/ #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to let you know, I've faced exact cloud-to-cloud situation, would be really glad to see this finished and merged in 👍 |
|
This enhancement is working perfectly with AWS, OCI and other clouds. Thank you for the effort. Hopefully this project will become active again someday. |
|
@stevefan1999-personal do you need/want assistance with this? |
|
@t0xicCode Sure, I have been busy about real life work and could hardly take time to finish some of the PRs myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
This could benefit some hypothetical cloud-to-cloud situation that had to be communicated though internet, e.g. interconnect from AWS to GCP without using their overpriced VPN service.
By default the advertise address would be
the same as the final bind addressanything you want if and only if it is a valid IP address otherwise empty to keep track with the default in memberlist, and advertise port is not yet changeable (implied by ClusterPort). The behavior is the same as before if you don't use the advertise address.This is not yet finished due to missing tests