Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trust_level numerator and denominator as flag when creating a client #1456

Open
boojamya opened this issue May 1, 2024 · 1 comment
Open
Labels
C: CLI COMPONENT: Command-Line Interface C: Relayer COMPONENT: Relayer T: Enhancement TYPE: Enhancement

Comments

@boojamya
Copy link
Contributor

boojamya commented May 1, 2024

The go relayer has a lot of overrides when it comes to creating a client (--client-tp, --client-unbonding-period, --max-clock-drift, ect). But it's missing one... trust_level.

I ran into this issue recently (screenshot attached).

In the intermittent I've hacked the relayer to give me the proper trust_level, but I do think this would be a great addition.

My initial thoughts are that this should only be added to rly tx client and not rly tx clients.

Screenshot 2024-04-25 at 4 14 39 PM

@jtieri jtieri added T: Enhancement TYPE: Enhancement C: CLI COMPONENT: Command-Line Interface C: Relayer COMPONENT: Relayer labels May 6, 2024
@jtieri
Copy link
Member

jtieri commented May 6, 2024

hey @boojamya!!

good call out, it would be nice to get this added to the rly tx client command. we could probably add it to both rly tx client and rly tx clients in case users want to use the same value for both clients, but we probably want to add some docs that make this behavior clear.

at this point it could be beneficial to add a document on client initialization to the docs directory that explains all of the flags that can be used during light client initialization.

is this something you would want to work on getting a PR up for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: CLI COMPONENT: Command-Line Interface C: Relayer COMPONENT: Relayer T: Enhancement TYPE: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants