Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing From<Infallible> for ClientError #1356

Open
rnbguy opened this issue Oct 2, 2024 · 0 comments
Open

missing From<Infallible> for ClientError #1356

rnbguy opened this issue Oct 2, 2024 · 0 comments

Comments

@rnbguy
Copy link
Collaborator

rnbguy commented Oct 2, 2024

Bug Summary

Looks like From<Infallible> for ClientError is removed. This is needed as we treat ClientState for ClientExecutionContext and ClientStateType different, and they are convertible between themselves via TryFrom or TryInto.

We can either bring back the From<Infallible> implementation or force conversion via From or Into without any failure.

This blocks the v0.55.0 release for ibc-client-cw. Probably we need to fix this and release v0.55.1 at ibc-rs side.

Details

The removed implementation in v0.55.0.

impl From<Infallible> for ClientError {
fn from(value: Infallible) -> Self {
match value {}
}
}

Version

v0.55.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant