Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up remaining Error associated types that do not use DecodingError #1349

Open
2 tasks
seanchen1991 opened this issue Sep 19, 2024 · 0 comments
Open
2 tasks
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR A: good-first-issue Admin: good for newcomers S: errors Scope: related to error handlings

Comments

@seanchen1991
Copy link
Contributor

Feature Summary

Most of the TryFrom conversions that convert from raw types in ibc-rs have been converted such that they now return DecodingError. A few hold outs remain that need to be cleaned up, notably the conversions in the ibc-query crate, as well as conversions for the Timestamp type in ibc-primitives. The latter is blocked on #1327 being completed first so that we don't introduce circular dependencies.

Proposal

  • Convert the TryFrom impls in the ibc-query crate to use DecodingError
  • Convert the TryFrom impls for the Timestamp type in ibc-primitives to use DecodingError once Deprecate the ibc-primitives crate #1327 has been completed
@Farhad-Shabani Farhad-Shabani added A: good-first-issue Admin: good for newcomers A: blocked Admin: blocked by another (internal/external) issue or PR S: errors Scope: related to error handlings labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR A: good-first-issue Admin: good for newcomers S: errors Scope: related to error handlings
Projects
Status: 📥 To Do
Development

No branches or pull requests

2 participants