Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement events for MsgServerV2 #7386

Open
2 of 6 tasks
Tracked by #7345
chatton opened this issue Oct 2, 2024 · 3 comments
Open
2 of 6 tasks
Tracked by #7345

Implement events for MsgServerV2 #7386

chatton opened this issue Oct 2, 2024 · 3 comments
Assignees
@DimitrisJim
Labels
feat: ibc-eureka

Comments

@chatton
Copy link
Contributor

chatton commented Oct 2, 2024 •
edited by DimitrisJim
Loading

Final Packet structure needs to be fully specified before we can do this.

  • Implement the EmitSendPacketEvents function for channel/v2
  • Implement the EmitRecvPacketEvents function for channel/v2
  • Implement the EmitAckPacketEvents function for channel/v2
  • Implement the EmitTimeoutPacketEvents function for channel/v2

In addition, events for CreateChannel/ProvideCounterparty should also be amended/added:
@chatton chatton mentioned this issue Oct 2, 2024
Open
30 tasks
@chatton chatton moved this to Ready for Development in IBC-GO Eureka Oct 2, 2024
@chatton chatton changed the title Implement events for SendPacket Implement events for MsgServerV2 Oct 7, 2024
@DimitrisJim
Copy link
Contributor

Events also needed for CreateChannel that generated channel identifier (I doubt provide counterparty needs one).

It currently has a bare-bones event emitted since that is needed to run the tests. Can be spec'ed out and changed if needed (currently only emits channelid)

@DimitrisJim
Copy link
Contributor

Spec PR for packet events: cosmos/ibc#1165

This was referenced Nov 12, 2024
Merged
Merged
@DimitrisJim DimitrisJim self-assigned this Nov 12, 2024
@DimitrisJim
Copy link
Contributor

Will wait for packet events until feedback from solidity team is given for them as Aditya requested in call. When spec PR is merged, can pick em up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
feat: ibc-eureka
Projects
IBC-GO Eureka
Status: Ready for Development
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chatton @DimitrisJim