Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock between gosec and golint #69

Open
kocubinski opened this issue Nov 21, 2022 · 0 comments
Open

Deadlock between gosec and golint #69

kocubinski opened this issue Nov 21, 2022 · 0 comments

Comments

@kocubinski
Copy link
Member

kocubinski commented Nov 21, 2022

Summary

	for s, _ := range snm.senders {
		orderedSenders.Set(s, s)
	}

Results in

Check failure on line 87 in types/mempool/sender_nonce.go
GitHub Actions / golangci-lint

File is not `gofumpt`-ed (gofumpt)

But

	for s := range snm.senders {
		orderedSenders.Set(s, s)
	}

results in

G705 (CWE-): expected either an append, delete, or copy to another map in a range with a map, got: "" (Confidence: MEDIUM, Severity: HIGH)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant