reject bank/MsgSend with fees > send value

[rigelrozanski]

https://etherscan.io/tx/0x1f73b43dc9c48cc131a931fac7095de9e5eba0c5184ec0c5c5f1f32efa2a6bab

seems like a this kind of safeguard could reduce a lot of anxiety... something we should all probably be aiming to accomplish.

CC @sunnya97

[alexanderbez]

What is your proposal here @rigelrozanski? To limit the fee based on some threshold relative the the sending amount? Wouldn't this ultimately depend on the tx type?

[rigelrozanski]

• fees cannot be greater than the send amount
• ONLY apply this to bank/MsgSend

I don't think there is an appropriate generic way to perform this check - ultimately every message type would need to have it's own ruleset as to what is appropriate -

[gamarin2]

The problem of inadvertently sending too much fees is not specific to the bank / MsgSend. I think this #3653 is a better way to address the issue.

[alexanderbez]

Indeed, both proposals are great and I think we should certainly perform #3653

[rigelrozanski]

no question that #3653 is a good idea. It helps this issue for anyone making a transaction with the CLI - however I nonetheless think that we ought to require this check at the state machine level - I think that many ETH wallets I've seen have warnings to prevent this "transaction-nightmare" but it nonetheless still happened - There is no reason this should be permitted to occur on anyone's custom tooling as well as the CLI

[fedekunze]

agree here with only covering standard transfers. I think both proposals are great 👍

[fedekunze]

is this something we want support ? @jbibla @faboweb @sabau what are your thoughts ?

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[tac0turtle]

closing this in favour of bankv2 epic. #17579