Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notes for docs from upgrading ibc #16487

Closed
faddat opened this issue Jun 9, 2023 · 5 comments · Fixed by #17262
Closed

notes for docs from upgrading ibc #16487

faddat opened this issue Jun 9, 2023 · 5 comments · Fixed by #17262
Assignees
Labels
T:Docs Changes and features related to documentation.

Comments

@faddat
Copy link
Contributor

faddat commented Jun 9, 2023

On a lark, today I tried to just

go get github.com/cosmos/[email protected]

and I really got suprisingly far, so I'm keeping notes here

  • remove github.com/cosmos/cosmos-sdk/client/docs/statik blank import from app.go
  • use cosmossdk.io modules for upgrade,
  • tmservice -> ctmservice
  • remove upgrade/client & calls to the upgrade client's legacy proposal handlers
  • KVStorePrefixIterator, sdk.StoreDecoderRegistry, sdk.NewKVStoreKeys, sdk.NewTransientStoreKeys, sdk.NewMemoryStoreKeys have moved to store types
  • StoreDecoderRegistry has moved to types/simulation
  • DiffKVStores has moved to testutil/sims

Tracking this work in hackmd here:

https://hackmd.io/e2ENN23qTkWFTm_f3NunGw

Please let me know if you'd like access. I wasn't aware that hackmd can be linked to markdown files on github, this is great.

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 9, 2023
@julienrbrt
Copy link
Member

Just curious what is this issue about? Do you think it is things we need to add in the UGPRADING.md?

@faddat
Copy link
Contributor Author

faddat commented Jun 9, 2023

I'm messing about with an ibc upgrade, and tracking changes that I make

I'll add more detail and context to the issue (by making a PR) when I've got a better grip on that

Kind of same as before I'm going to try and construct a "featureful" "ideal chain" and use that for integration work

@julienrbrt
Copy link
Member

Alright, it seemed like an UPGRADING.md, and that file should be the canonical file of what is needed to upgrade to v0.50. If you find something missing, let's add it there. Import changes are mentioned in the changelog only, so it will be normal if you do not find it there. Do note that we haven't completed the work on the upgrading.md, so much can be missing (#16473)
Anyway, awesome that you are already playing with v0.50!!

@julienrbrt julienrbrt added T:Docs Changes and features related to documentation. and removed needs-triage Issue that needs to be triaged labels Jun 9, 2023
@faddat
Copy link
Contributor Author

faddat commented Jun 9, 2023

Yep, I figured it wasn't finished, and figured I could lend a hand because I wanna try out some of these new swanky features :)

@faddat
Copy link
Contributor Author

faddat commented Jun 9, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants