v0.47.x (initParamsKeeper init params keeper and its subspaces) WithKeyTable deprecation

[RaulBernal]

I've noticed that SimAPP is not using WithKeyTable at initParamsKeeper , specially in gov Subspace

cosmos-sdk/simapp/app.go

Line 734 in cdb519f

paramsKeeper.Subspace(govtypes.ModuleName)

Last recent version of Gaiad still use them:
https://github.com/cosmos/gaia/blob/v15.1.0/app/keepers/keepers.go#L440

My question is, it is secure/advised to use the last way (simApp)?
Shall I do any other changes (or upgrades) in the source code?
This change would be a consensus-breaking one?

Thanks in advance

[julienrbrt]

We are setting them in the upgrade handler of simapp:

cosmos-sdk/simapp/upgrades.go

Line 32 in cdb519f

for _, subspace := range app.ParamsKeeper.GetSubspaces() {

[RaulBernal]

Oh clear!
So Gaiad didn't do
https://github.com/cosmos/gaia/blob/1e7b5171ff1d6c8626aa4a0f049a10fefd69823e/app/upgrades/v15/upgrades.go#L48
abd this is the reason they didn't change at app.go