Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign the assemblies that we publish #434

Open
Tracked by #388
mwadams opened this issue Sep 23, 2024 · 2 comments
Open
Tracked by #388

Sign the assemblies that we publish #434

mwadams opened this issue Sep 23, 2024 · 2 comments
Milestone

Comments

@mwadams
Copy link
Contributor

mwadams commented Sep 23, 2024

We have had a request from @gregsdennis to sign the assemblies, so that we can support upstream users who have signed assemblies, without producing a warning.

@mwadams mwadams mentioned this issue Sep 23, 2024
5 tasks
@mwadams mwadams added this to the VNext milestone Sep 23, 2024
@idg10
Copy link
Contributor

idg10 commented Oct 2, 2024

Could you or @gregsdennis clarify whether this is a request to:

  • make these strongly-named assemblies with a corresponding signature (i.e., nothing certificate based, just the old-school strong name signature that we're now all encouraged not to rely on)
  • embed an authenticode code signature in the actual DLLs themselves
  • generate a signature for the NuGet package

Or Some combination of the above?

I'm not clear on what exactly is blocking upstream users, so I'm not sure exactly what will be required to support them properly.

@gregsdennis
Copy link

The first one. I've been signing my packages forever because it was requested of me long ago. And the system still complains when you reference an unsigned package from a signed one.

I am curious why it's discouraged now, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants