Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to rely entirely on dotnet dependencies without Corvus.Json.ExtendedTypes #285

Closed
xaviergxf opened this issue Nov 28, 2023 · 3 comments · Fixed by #300
Closed

Ability to rely entirely on dotnet dependencies without Corvus.Json.ExtendedTypes #285

xaviergxf opened this issue Nov 28, 2023 · 3 comments · Fixed by #300
Assignees
Labels
bug Something isn't working review This issue needs review. The goal is unclear or disputed.

Comments

@xaviergxf
Copy link

Hello,

When trying to use Corvus.JsonSchema library to generate DTOs in a large project on dotnet 8 i found some conflicts regarding extensions methods on IEnumerable. There are conflicts between System.Interactive (a dependency of a dependency of Corvus.Json.ExtendedTypes) and MoreLinq.
Do you have any plans to support generating these DTOs without any external dependency outside of the target framework? An idea would be to choose the T4 template when use the CLI to generate this?
What do you think?

Thanks

@mwadams
Copy link
Contributor

mwadams commented Mar 5, 2024

Apologies! I missed this when it first appeared.

Can you give me examples of the conflicts?

@mwadams mwadams self-assigned this Mar 5, 2024
@mwadams mwadams added the review This issue needs review. The goal is unclear or disputed. label Mar 5, 2024
@mwadams
Copy link
Contributor

mwadams commented Mar 5, 2024

It seems that the reference to Corvus.Extensions is the issue here.

This dependency can be removed without issue.

@mwadams mwadams added the bug Something isn't working label Mar 5, 2024
@mwadams mwadams linked a pull request Mar 5, 2024 that will close this issue
@mwadams
Copy link
Contributor

mwadams commented Mar 5, 2024

The PR addresses these collisions (by removing the transitive dependencies).

It does not remove the dependency on Corvus.Json.ExtendedTypes which is essential to the generated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review This issue needs review. The goal is unclear or disputed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants