Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle all navigation (record/page) inside modal flows #1389

Closed
Fajfa opened this issue Aug 23, 2023 · 3 comments · Fixed by #1465
Closed

Properly handle all navigation (record/page) inside modal flows #1389

Fajfa opened this issue Aug 23, 2023 · 3 comments · Fixed by #1465
Assignees
@kelanik8
Labels
bug Something isn't working frontend Frontend code changes (Javascript, Typescript, Vue.js)
Milestone
2023.9.0

Comments

@Fajfa
Copy link
Member

Fajfa commented Aug 23, 2023 •
edited by katrinDY
Loading

Some record/page navigation in modals doesn't open the new view in the modal itself:

  • Record viewers
  • Calendar block click on event
  • Geometry block click on event
  • Others to be found

We need to keep the modal flow inside the modal itself
@Fajfa Fajfa added bug Something isn't working enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js) and removed enhancement New feature or request labels Aug 23, 2023
@Fajfa Fajfa added this to the 2023.9.0 milestone Aug 23, 2023
@kelanik8
Copy link
Contributor

kelanik8 commented Sep 25, 2023 •
edited
Loading

Fixed

  • Calender
  • Geometry
  • Chart -> open record -> add new -> create page doesn't show, only on page resize
  • Organizer
  • Record
  • Record list

@kelanik8
Copy link
Contributor

@katrinDY there was no code changes

@katrinDY
Copy link
Contributor

Found this:
5

@kelanik8 kelanik8 linked a pull request Oct 3, 2023 that will close this issue
Add a continuous modal navigation flow for all page block #1465
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelanik8 kelanik8

Labels
bug Something isn't working frontend Frontend code changes (Javascript, Typescript, Vue.js)
Projects
None yet
Milestone
2023.9.0
Development

Successfully merging a pull request may close this issue.

Add a continuous modal navigation flow for all page block cortezaproject/corteza
3 participants
@Fajfa @kelanik8 @katrinDY