Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to remove an icon once it has been added #1217

Closed
Bojan-Svirkov opened this issue May 22, 2023 · 2 comments · Fixed by #1379
Closed

Add an option to remove an icon once it has been added #1217

Bojan-Svirkov opened this issue May 22, 2023 · 2 comments · Fixed by #1379
Assignees
@KinyaElGrande @katrinDY
Labels
backend Backend server changes (GO) enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js)
Milestone
2023.9.0

Comments

@Bojan-Svirkov
Copy link
Contributor

Description of the bug

Once you add an icon to your compose page, there is no way of actually removing the added icon from the list.

Reproduction steps

  1. Go in one of your namespaces
  2. Open any page
  3. Under Page Icon, press on the configure page icon button
  4. Add an icon
  5. After adding the icon, deselect it and see that you don't have an option to completely remove the icon from the list.

Expected behavior

We should be able to have an option to remove an icon from our list once it has been added to the list.

Screenshot/Video

Image

Version

Branch: 2023.3.x
@Bojan-Svirkov Bojan-Svirkov added this to the 2023.3.3 milestone May 22, 2023
@Bojan-Svirkov Bojan-Svirkov added enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js) labels May 22, 2023
@katrinDY katrinDY added the backend Backend server changes (GO) label May 25, 2023
@katrinDY katrinDY self-assigned this May 25, 2023
@katrinDY
Copy link
Contributor

katrinDY commented Jun 5, 2023

for today: continue working on task

@katrinDY katrinDY modified the milestones: 2023.3.3, 2023.3.4 Jun 14, 2023
@katrinDY katrinDY modified the milestones: 2023.3.4, 2023.3.5, 2023.3.x Jul 7, 2023
@katrinDY katrinDY modified the milestones: 2023.3.x, 2023.9.0 Aug 21, 2023
@katrinDY katrinDY linked a pull request Aug 21, 2023 that will close this issue
2023.3.x feature delete page icon #1379
Merged
6 tasks
@KinyaElGrande KinyaElGrande mentioned this issue Oct 13, 2023
Closed
@KinyaElGrande KinyaElGrande linked a pull request Oct 13, 2023 that will close this issue
Add an option to remove page icon #1473
Closed
@katrinDY katrinDY removed a link to a pull request Oct 17, 2023
Add an option to remove page icon #1473
Closed
@katrinDY
Copy link
Contributor

lgtm; leaving this here if you wanna test it @Fajfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KinyaElGrande KinyaElGrande

@katrinDY katrinDY

Labels
backend Backend server changes (GO) enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js)
Projects
None yet
Milestone
2023.9.0
Development

Successfully merging a pull request may close this issue.

2023.3.x feature delete page icon cortezaproject/corteza
4 participants
@vicpatel @KinyaElGrande @Bojan-Svirkov @katrinDY