We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If OIDC page return non-OK status, the current behavior would log the body, which may fill up the disk if it's large enough.
https://github.com/coreos/go-oidc/blob/v3/oidc/oidc.go#L244-L246
Would it be OK not to log the body?
func (p *Provider) UserInfo ... if resp.StatusCode != http.StatusOK { return nil, fmt.Errorf("%s: %s", resp.Status, body) } }
The text was updated successfully, but these errors were encountered:
If you'd like to send a PR to limit the amount of information read, happy to take it!
Sorry, something went wrong.
@ericchiang Any suggestion for the limit? Or if the body size reaches out threshold just ignore the body?
limit the size of the logged response to 2048 bytes in error cases
3003d48
Fixes coreos#306
Successfully merging a pull request may close this issue.
If OIDC page return non-OK status, the current behavior would log the body, which may fill up the disk if it's large enough.
https://github.com/coreos/go-oidc/blob/v3/oidc/oidc.go#L244-L246
Would it be OK not to log the body?
The text was updated successfully, but these errors were encountered: