-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kola tests for unique bootfs work #2953
Comments
For 1., note that you can make a dummy e.g. ext4 filesystem ahead of time using e.g.:
(But called from golang.) For 2., it'd be interesting to enhance the external test harness to handle expected initrd failures. E.g. we could have a new directive like That would also allow us to convert |
Thanks, this clarifies some of my questions indeed! |
The above isn't functional, I uploaded it just to set a starting point and discuss my concerns.
Is it enough for me to create an additional fakeboot partition? I saw the module-setup.sh just not sure if I understand it correctly? |
cc @jlebon |
See: coreos#2953 tests/ignition: Use ignition config to create a second bootfs Co-authored-by: JB Trystram <[email protected]> mantle/kola: Create functions to grep for patterns
See: coreos#2953 tests/ignition: Use ignition config to create a second bootfs Co-authored-by: JB Trystram <[email protected]> mantle/kola: Create functions to grep for patterns
See: coreos#2953 tests/ignition: Use ignition config to create a second bootfs Co-authored-by: JB Trystram <[email protected]> mantle/kola: Create functions to grep for patterns
See: coreos#2953 tests/ignition: Use ignition config to create a second bootfs Co-authored-by: JB Trystram <[email protected]> mantle/kola: Create functions to grep for patterns
See: #2953 tests/ignition: Use ignition config to create a second bootfs Co-authored-by: JB Trystram <[email protected]> mantle/kola: Create functions to grep for patterns
Fixed by: #3647 |
We've added new services in coreos/fedora-coreos-config#1269 and coreos/fedora-coreos-config#1540 which verify that there is only one
boot
filesystem. We currently don't have CI that exercises them.Add tests for these. I see at least one for each:
boot
filesystem on it, and verify thatcoreos-unique-boot.service
fails as expected.boot
filesystem and verify thatcoreos-ignition-unique-boot.service
fails as expected.We have at least one test already which verifies Ignition failure in the initrd (see
qemufailure.go
). Using that code as a base for the new tests would be a good starting point.The text was updated successfully, but these errors were encountered: