Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip all user.* xattrs in upload-oscontainer #2401

Closed
cgwalters opened this issue Sep 1, 2021 · 1 comment
Closed

strip all user.* xattrs in upload-oscontainer #2401

cgwalters opened this issue Sep 1, 2021 · 1 comment

Comments

@cgwalters
Copy link
Member

cgwalters commented Sep 1, 2021 •
edited
Loading

xref BZ https://bugzilla.redhat.com/show_bug.cgi?id=2000195

Seen in an OCP upgrade:

error setting extended attributes on "/extensions
/dependencies/kernel-core-4.18.0-305.12.1.el8_4.x86_64.rpm": error setting value of extended attribute "user.Librepo.checksum.mtime" on "/extensions/dependencies/kernel-core-4.18.0-305.12.1.el8_4.x86_64.rpm": operation not
 supported

I this is something librepo writes as an optimization, but we should just strip it (and really all user.* xattrs) out because they don't work on tmpfs.
@cgwalters
Copy link
Member Author

cgwalters commented Sep 2, 2021 •
edited
Loading

A discovery I made here is that in the major extensions rework done in #2028 we stopped writing these user.* xattrs.

So the machine-os-content in the 4.8+ stream does not have this problem, but earlier versions i.e. ≤ 4.7 will.

cgwalters added a commit to cgwalters/coreos-assembler that referenced this issue Sep 2, 2021
@cgwalters
download-extensions: Strip out user.* xattrs
4b37dd8 
xref BZ https://bugzilla.redhat.com/show_bug.cgi?id=2000195

librepo writes these xattrs, but unfortunately Linux `tmpfs`
doesn't support `user.*` xattrs.  And the OpenShift MCO
falls back to doing `podman cp` in some cases, which fails
when these xattrs are present.

Since the xattrs are just cache data and not functional,
just strip them out.

Closes: coreos#2401
@cgwalters cgwalters mentioned this issue Sep 2, 2021
Merged
cgwalters added a commit to cgwalters/coreos-assembler that referenced this issue Sep 2, 2021
@cgwalters
download-extensions: Strip out user.* xattrs
df26e34 
xref BZ https://bugzilla.redhat.com/show_bug.cgi?id=2000195

librepo writes these xattrs, but unfortunately Linux `tmpfs`
doesn't support `user.*` xattrs.  And the OpenShift MCO
falls back to doing `podman cp` in some cases, which fails
when these xattrs are present.

Since the xattrs are just cache data and not functional,
just strip them out.

Closes: coreos#2401
cgwalters added a commit that referenced this issue Sep 2, 2021
@cgwalters
download-extensions: Strip out user.* xattrs
1457bde 
xref BZ https://bugzilla.redhat.com/show_bug.cgi?id=2000195

librepo writes these xattrs, but unfortunately Linux `tmpfs`
doesn't support `user.*` xattrs.  And the OpenShift MCO
falls back to doing `podman cp` in some cases, which fails
when these xattrs are present.

Since the xattrs are just cache data and not functional,
just strip them out.

Closes: #2401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cgwalters