Cordapp Plugin - Usage of deprecated compile configuration

[raynay-r]

The Cordapp plugin seems to only include dependencies declared with the compile configuration in the fat jar. Since the compile configuration is deprecated and should be replaced with either implementation or api, the plugin should imho also support including these dependencies. More information on that topic can be found here.

I think the problem is in CordappPlugin.kt#L182. Here the deprecated constant RUNTIME_CONFIGURATION_NAME is used. According to the documentation this constant should be replaced with RUNTIME_ELEMENTS_CONFIGURATION_NAME.

I tested the behavior with the following two tasks:

tasks.register("listd1") {
    doLast {
        println("List RUNTIME_ELEMENTS")
        val runtimeConfiguration = project.configurations.single {it.name == RUNTIME_ELEMENTS_CONFIGURATION_NAME}
        runtimeConfiguration.allDependencies.map { println(it) }
        println("Finished RUNTIME_ELEMENTS")
    }
}

tasks.register("listd2") {
    doLast {
        println("List RUNTIME")
        val runtimeConfiguration = project.configurations.single {it.name == RUNTIME_CONFIGURATION_NAME}
        runtimeConfiguration.allDependencies.map { println(it) }
        println("Finished RUNTIME")
    }
}

From my point of view RUNTIME_ELEMENTS_CONFIGURATION_NAME provides the correct behavior. If you are interested in making the change I could provide a pull request.

[chrisr3]

Thank you for your report. These plugins all use Gradle's deprecated compile and runtime configurations internally, but we cannot trivially change to using their modern replacements without also affecting how the plugins behave in everyone's build.gradle files. For example, the cordapp plugin would then also include any implementation or api dependencies inside the CorDapp "semi-fat" jar, and this isn't something that we can hide behind a minor version change.

[raynay-r]

Are you considering updating the behavior and making a new major release? Because in my case it makes difficult to use the plugin in a new project. I use the buildSrc folder to declare dependencies for multiple modules and the plugin forces me to either declare the dependencies twice or declare them as compile.