Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tail sampling #361

Merged
merged 1 commit into from
Feb 7, 2024
Merged

feat: add tail sampling #361

merged 1 commit into from
Feb 7, 2024

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Feb 5, 2024

Description

Fixes ES-199

This allows users to use tail-sampling-values.yaml to quickly spin up additional opentemeletry-collector-gateway deployment.

Agents will send data to the gateway, while gateway will do tail sampling descisions

How Has This Been Tested?

  • kind cluster locally

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv marked this pull request as ready for review February 5, 2024 13:23
@povilasv povilasv marked this pull request as draft February 5, 2024 14:03
@povilasv povilasv force-pushed the tail-sampling branch 3 times, most recently from b344829 to a2eaeff Compare February 6, 2024 15:58
@povilasv povilasv marked this pull request as ready for review February 6, 2024 15:58
@povilasv povilasv requested a review from matej-g February 7, 2024 08:20
@povilasv povilasv merged commit 669d37b into master Feb 7, 2024
4 of 5 checks passed
@povilasv povilasv deleted the tail-sampling branch February 7, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royfur royfur royfur left review comments

@itsmegb itsmegb itsmegb left review comments

@matej-g matej-g matej-g approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@povilasv @itsmegb @matej-g @royfur