-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining things to fix after GitHub Pages migration. #233
Comments
Here are relevant parts of the Apache conf: From # Nix shell for the coq-nix-toolbox
RewriteRule ^nix/toolbox(|/)$ https://github.com/coq-community/coq-nix-toolbox/archive/master.tar.gz [R,L]
# Nix shell for math-comp
RewriteRule ^nix/math-comp(|/)$ https://github.com/math-comp/math-comp-nix/archive/v2.tar.gz [R,L]
# Main page of Coq Workshop has moved to external website
RewriteRule ^coq-workshop(|/)$ https://coq-workshop.gitlab.io/ [R=301,L]
# Mike Nahas's tutorial is not hosted on the Coq website anymore
RewriteRule ^tutorial-nahas(|.html|/)$ https://mdnahas.github.io/doc/nahas_tutorial [R=301,L]
RewriteRule ^files/nahas_tutorial.v$ https://mdnahas.github.io/doc/nahas_tutorial.v [R=301,L]
# opam/www/using.html and co. moved to opam-using early 2019
RewriteRule ^opam/www/(layout|packaging|using).html$ opam-$1.html [R=301,L]
# Awesome Coq tools section replaced related-tools page mid 2021
RewriteRule ^related-tools(|.html|/)$ https://github.com/coq-community/awesome-coq#tools [NE,R=301,L] From RewriteRule ^coq-workshop/files/(.*) files/$1 [L]
RewriteRule ^coq-workshop/2009/cfp$ /news/69.html [L]
RewriteRule ^library-eng.html$ /stdlib [L,R=301]
RewriteRule ^doc-eng.html$ /refman [L,R=301]
Redirect /cocorico https://github.com/coq/coq/wiki
Redirect /faq https://github.com/coq/coq/wiki/The-Coq-FAQ
## Pierre : redirect old bugs to github issues
## First, special rules for bug numbers that changed during the transition
Include /etc/apache2/bugzilla-compat.conf
## When the bug number is the same, a generic rule is enough
RewriteCond %{QUERY_STRING} ^id=([0-9]+)
RewriteRule ^bugs/show_bug.cgi$ https://github.com/coq/coq/issues/%1? [L,R=301]
## Pierre : shortcut bug/1234 -> https://github/com/coq/coq/issues/1234
RewriteRule ^bug/([0-9]+)$ https://github.com/coq/coq/issues/$1 [L,R=301] The |
@vbgl FYI, I've proceeded to do that for the latest versions of each release between V8.0 and V8.8, so you might want to add these to the doc index page.
On this aspect, I think I will proceed with the removal if there is no opposition.
On this aspect as well, I think I will proceed with the removal if there is no opposition (and an additional redirection to replace it). cc @maximedenes FYI |
Regarding this:
I've done it now, but unfortunately, since these links were for use with cc @CohenCyril @palmskog FYI |
@Zimmi48 but I thought we agreed to move all Nix stuff to |
Ah right, I completely forgot that this was our conclusion. For now, I have updated the references in https://github.com/math-comp/math-comp/wiki/Using-nix and https://github.com/coq-community/coq-nix-toolbox/blob/master/README.md (documentation) and I have opened a PR at coq-community/templates#122 for the templates. For the templates, I feel like having the raw link is no big deal. For the rest, we can indeed consider the |
As discussed in coq/coq#18547 and #233. Fixes #238.
Following the 8.19 release, we have decided with @SkySkimmer to not update the refman repository that provided a moving target URL for the refman (this repository could now be deleted as it serves no purpose anymore) and instead redirect https://coq.inria.fr/refman to a fixed version of the refman corresponding to the current version like what was already the case for https://coq.inria.fr/distrib/current/refman and https://coq.inria.fr/stdlib. I also propose to resolve another item in the list above by ditching the HTML redirects and keeping only the 404 Javascript redirects. |
done |
A lot of links were broken with the migration to GitHub Pages because it doesn't support HTTP redirects. A solution based on Javascript on a 404 page was proposed by @huynhtrankhanh in #232 and it has allowed resolving the most pressing broken link issues. It can be extended to fix other broken links that need to be fixed.
We can live with this for a couple of weeks to see if we are satisfied with this solution, or if we prefer to migrate to an infrastructure that supports HTTP redirects, like @silene said he could explore.
I'm opening this issue to make the list of remaining things to fix after #232 (already fixed issues are #230, as well as the long-standing issues #196, #188, #131, #111, #110).
Tasks
Regarding point 4 above, removing the https://github.com/coq/refman repository means that we would no longer provide a "moving target" refman version, and maybe that's a good thing (I was already suggesting this in #111). People could still craft "moving target" URLs based on our redirection mechanism. This would also make the release process simpler (one manual step to remove).
The text was updated successfully, but these errors were encountered: