Adapt to MC2 and newer versions of Coq #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It still does not compile with coq-master. However, I failed to build coq-master locally and thus could not fix (or even reproduce) the issue. I don't know who is the right person to ping, but let me try: @palmskog @anton-trunov |
|
I guess the issue has been fixed by coq/opam#3200. I will retry. |
|
@pi8027 I'm happy to merge this once CI passes, but no cycles to help, unfortunately. I can even give you merge privileges if you want. |
|
Done. The next TODO is to put it back to the CI of Coq and MathComp. |
pi8027
commented
Nov 13, 2024
|
@pi8027 you should now have merge access (I added the mathcomp-overlay team), so feel free to merge this yourself. Thanks for reviving this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.