-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling jobs only in CI. #62
Comments
Related to this, something that I still didn't understand is why some jobs marked as |
I do not understand this sentence. Why put |
Because otherwise the generated workflow contained a job building mathcomp (full) even though I only needed one for mathcomp-ssreflect IIRC. |
This was a bug, I fixed it in #75, why exclude coq-shell, bigenough and heq though? |
Coq-shell, I don't know, but the rest of them are not really expected to be compatible with Coq master, are they? |
I see I misread, I thought all of them were suppressed for released versions. |
In coq-community/paramcoq#75, I had to put
coqPackages.mathcomp.job = false;
because I had also putcoqPackages.mathcomp.override.version = "master";
but there was no reason to have a CI job building the full mathcomp.In jwiegley/category-theory#21, since no Cachix was set, I wanted to avoid the inefficiency of having dependencies built in separate jobs (only to be rebuilt in the main job). Therefore, I had to put a number of
job = false;
(more for the "dev" bundles than for the others). In the case of Coq, the unwanted consequence is that Coq is silently skipped when we try to build it, and it is only actually built later on, while trying to build ssreflect: https://github.com/Zimmi48/category-theory/runs/3493747463?check_suite_focus=true#step:10:9There should be a way of excluding a job from CI without making
nix-build --job
a no-op.The text was updated successfully, but these errors were encountered: