Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vine: nonblocking manager.wait() doesn't return results #4003

Open
tphung3 opened this issue Dec 9, 2024 · 3 comments
Open

vine: nonblocking manager.wait() doesn't return results #4003

tphung3 opened this issue Dec 9, 2024 · 3 comments
Labels
bug For modifications that fix a flaw in the code. TaskVine

Comments

@tphung3
Copy link
Contributor

tphung3 commented Dec 9, 2024

Description: Setting the result wait time of the manager to 0 results in a hanging behavior in the application.

Desired behavior: The application should not hang but instead keep going to the end, per

# If 0, return immediately with a complete task if one available, or None otherwise.
.

How to reproduce: set this wait time to 0 in probably any test in taskvine/test to reproduce the issue. I observed this issue with taskvine/test/vine_python_serverless.py and taskvine/test/vine_python_task.py

@tphung3 tphung3 added bug For modifications that fix a flaw in the code. TaskVine labels Dec 9, 2024
@btovar
Copy link
Member

btovar commented Dec 9, 2024

Does it hang or busy waits? Looking at the code, it should be busy waiting. When wait time is zero the manager returns immediately with a task already retrieved. Is this a bug with the code or the documentation?

@tphung3
Copy link
Contributor Author

tphung3 commented Dec 10, 2024

I think this is a bug. If there's a test with m.wait(0), the worker for that test will time out because of no work sent.

@tphung3 tphung3 closed this as completed Dec 10, 2024
@tphung3 tphung3 reopened this Dec 10, 2024
@btovar
Copy link
Member

btovar commented Dec 10, 2024

Is the bug with the test that calls m.wait(0)? What are your intentions for calling wait(0) instead of using a timeout larger than 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For modifications that fix a flaw in the code. TaskVine
Projects
None yet
Development

No branches or pull requests

2 participants