Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: transfers between members of different organisations #638

Open
franpb14 opened this issue May 13, 2021 · 1 comment · May be fixed by #639
Open

Feature: transfers between members of different organisations #638

franpb14 opened this issue May 13, 2021 · 1 comment · May be fixed by #639
Assignees
@franpb14
Labels
feature

Comments

@franpb14
Copy link
Collaborator

I will make the current "time transfer for this offer" button work even if it is an offer from another organisation. This will allow different organisations to exchange time with each other.

The button will work as follows when the exchange is between different organisations:
member A and his organisation give one hour and member B and his organisation get one hour. So now the sum of time of the members of organisation A will be -1 and of organisation B will be 1.

For this Issue the way to share an offer from another organisation will be via URL, then we will look at how to implement a search engine.
@franpb14 franpb14 self-assigned this May 13, 2021
@sseerrggii
Copy link
Contributor

photo5783001618583762642

I think is a good first step. Someday we can show only accountability between organizations, limits of credit between organitzacions or other rules for interbank exchanges

franpb14 added a commit that referenced this issue May 15, 2021
@franpb14
feat: time can now be spent on an offer from another organization
11048ec 
To do this, 3 transfers are made: member1 --> organization1; organization1 --> organization2; organization2 --> member2. In order to reuse the implemented code and not make it unnecessarily long, it was necessary to make some modifications to the implemented code. Issue #638.
franpb14 added a commit that referenced this issue May 15, 2021
@franpb14
tests: covered the new use case and other tests have been adapted
ca70d10 
the transfer between users from different organisations has been carefully tested and tests like those of transfer_factory which required a parameter. Issue #638.
franpb14 added a commit that referenced this issue May 16, 2021
@franpb14
feat: organisations can also transfer time for the offer
1c61670 
Sergi says that an organisation can also give time for an offer from another organisation so now it also works if an admin chooses an organisation's account. I have also refactored my code a bit. Issue #638.
franpb14 added a commit that referenced this issue May 16, 2021
@franpb14
tests: added tests for the case where the organisation is the source.…
4f59f9d 
… Issue #638
@franpb14 franpb14 linked a pull request May 16, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franpb14 franpb14

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Time exchanges can now be made between organisations coopdevs/timeoverflow
2 participants
@sseerrggii @franpb14