Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump macos version used for CI from 12 to 13 #28

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

cooljeanius
Copy link
Owner

also configure yamllint

also configure yamllint
@cooljeanius
Copy link
Owner Author

ok, so, the failures here are actually legitimate, so I'm going to need to dig into the actual code here to fix it...

@cooljeanius
Copy link
Owner Author

nsfont.m:292:59: warning: using %s directive in NSString which is being passed as a formatting argument to the formatting method [-Wcstring-format-directive]
      ascii_printable = [[NSString alloc] initWithFormat: @"%s", chars];
                                                          ^
/Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSString.h:380:1: note: method 'initWithFormat:' declared here
- (instancetype)initWithFormat:(NSString *)format, ... NS_FORMAT_FUNCTION(1,2);
^
nsfont.m:908:28: error: 'ATSFontFindFromPostScriptName' is unavailable
      ATSFontRef atsFont = ATSFontFindFromPostScriptName
                           ^
/Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/ApplicationServices.framework/Frameworks/ATS.framework/Headers/ATSFont.h:828:1: note: 'ATSFontFindFromPostScriptName' has been explicitly marked unavailable here
ATSFontFindFromPostScriptName(
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
1 warning and 2 errors generated.
gmake[1]: *** [Makefile:463: nsfont.o] Error 1
gmake[1]: *** Waiting for unfinished jobs....

...and some other things I noticed in the process...
@cooljeanius cooljeanius marked this pull request as ready for review November 20, 2024 19:18
Copy link
Owner Author

@cooljeanius cooljeanius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@cooljeanius cooljeanius merged commit c6a10e4 into master Nov 20, 2024
14 checks passed
@cooljeanius cooljeanius deleted the macos-12-to-13 branch November 20, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant