Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"converse-root" is created twice for the "embedded" view mode #3296

Open
udaysv opened this issue Dec 25, 2023 · 0 comments
Open

"converse-root" is created twice for the "embedded" view mode #3296

udaysv opened this issue Dec 25, 2023 · 0 comments
Milestone

Comments

@udaysv
Copy link

udaysv commented Dec 25, 2023

Describe the bug
I use Converse js lib in my web app with embedded view mode. I want to place the Converse container inside my app as one container. But I was able to see it two times.

 let converseSettingsObj = {
        websocket_url: boshUrl,
        auto_login: true,
        authentication: "login",
        keepalive: true,
        allow_logout: true,
        auto_list_rooms: false,
        theme: "concord",
        auto_reconnect: true,
        play_sounds: true,
        sounds_path: `/sounds/`,
        notification_icon: '/logo/',
        view_mode: "embedded",
        singleton: false,
        show_tab_notifications: true,
        discover_connection_methods: false,
        auto_register_muc_nickname: true,
        notify_all_room_messages: true,
        auto_subscribe: true,
        allow_contact_requests: true,
        locked_domain: xmppDomain,
        muc_domain: xmppMUCDomain,
        allowed_image_domains: xmppImageDomains,
        allowed_audio_domains: xmppAudioDomains,
        allowed_video_domains: xmppVideoDomains,
        locked_muc_domain: true,
        show_controlbox_by_default: false,
        clear_cache_on_logout: true,
        allow_user_trust_override: "off",
        allow_message_styling: true,
        stanza_timeout: 90000,
        csi_waiting_time: 3,
        auto_away: 3,
        auto_xa: 6,
        show_message_avatar: false,
        time_format: "hh:mm A",
        allow_non_roster_messaging: true,
        idle_presence_timeout: 900,
        muc_respect_autojoin: true,
        reuse_scram_keys: true,
        muc_subscribe_to_rai: true,
        enable_smacks: true,
        visible_toolbar_buttons: {
            call: false,
            spoiler: false,
            emoji: true,
            toggle_occupants: false,
        },
        whitelisted_plugins: ["main_plugin"],
    }

To Reproduce
Steps to reproduce the behavior:

  1. Import the CDN links of converse js lib into my app of react project
  2. Add <converse-root></converse-root> tag in your container (Add only once in the body tag)
  3. Observe the Dev Tools of the page elements. It shows two tags in the DOM
  4. See the error

Expected behavior
It should be shown only once in DOM

Screenshots
converse_root
converse-circle

Environment (please complete the following information):

  • Browser Chrome, Firefox, Edge
  • Converse.js version: 10.1.4
@jcbrand jcbrand modified the milestone: 11.0.0 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants