**Fix:** Remove hasIconOffset, add <Example/> instead of <Example> #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2020 00:41
Remove hasIconOffset property to fix the extra padding for trees with no children, removes misalignment Use <Example/> instead of <Example> to fix the warning in the code example Fixes contiamo#1321
Add arrows for freeze tree by removing the condition preventing this
|
Hi @rimildeyjsr! Looks like there is an issue with the columns still: columns are children of tables, but there is no indentation showing that (columns should be shown one level deeper under tables)
|
|
@mpotomin - Ah had not taken this into account, will fix this as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hasIconOffset property to fix the extra padding for trees with no children, removes misalignment
Use instead of to fix the warning in the code example
Fixes #1321
Summary
The last level of a nested tree was being misaligned with the previous level.
The cause was the
hasIconOffsetbeing set true for when you have an icon or a tag along with a tree that has no children. It was adding some extra padding using the formulapaddingLeft + theme.space.element * level + (hasIconOffset ? theme.space.element : 0)}px;On removing the
hasIconOffset, the last levels get aligned with appropriate padding. I am removing this property altogether because any nested tree with no children was getting misaligned, and the property did not provide any other functionality.Also, added arrows to the style of the freeze tree, as suggested in the issue
Related issue
Fixes #1321
To be tested
Me
localhost:6060Tester 1
Tester 2