-
Notifications
You must be signed in to change notification settings - Fork 76
Added newsListCountItems & newsListFetchItems hooks #432
base: main
Are you sure you want to change the base?
Conversation
|
||
|
||
## Return Values | ||
Return an `integer`, `null` or `false`. If you return an integer, this news |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not exactly true. Returning null
or false will have the same result, the foreach
loop will continue to call the next hook. Only returning an integer value will return a result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I don't know why I wrote this. Maybe I read continue
as exit
.
|
||
1. *array* `$newsArchives` | ||
|
||
An array containing news archives IDs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
containing news archive IDs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some difficulties with english, so I'm going to trust you on this. To be clear, it means several IDs of several archive(s)?
Is it invariable ? I can't find it on the web.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sebj54, the array contains all ids of the news archives you've chosen in the back end. So the wording "An array containing the news archive IDs chosen in the front end module settings" would actually be the best :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little example. You would say coffee tables and not coffees tables, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Toflar I agree with you, the description should be more explicit, I'll make a commit with your suggestion.
@aschempp To be honest, you are really making me doubt about it! Your example doesn't look similar for me because there could several tables for a single coffee, no?
Let's take a human nose for the example (because a human has only one nose like the archive has only one ID).
So, I would say humans noses instead of human noses...
You're starting to loose me at this point, I really should revise English, especially possesive.
To finish, I know you aren't here to teach me English but I really don't understand why news archives is right when news archives IDs is not (thank you for your patience).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I don't know english rules, I'm a learning by doing type and news archives IDs just sounds wrong to me. Regarding news archives, thats just because news is both singular and plural. I would say calendar archives and not calendars archives.
Maybe a native speaker like @blairwinans could shed some light?
No description provided.