Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add flat mode for the tree picker #567

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

baumannsven
Copy link
Member

No description provided.

@baumannsven baumannsven self-assigned this Apr 10, 2021
@baumannsven baumannsven added this to the 2.2.0 milestone Apr 10, 2021
Copy link
Member

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the changes requested above, I am not sure if expanding the Environment is the best solution but I lack an alternative approach.
Maybe @dmolineus or @stefanheimes have some thoughts on this?

src/Contao/View/Contao2BackendView/TreePicker.php Outdated Show resolved Hide resolved
src/Contao/View/Contao2BackendView/TreePicker.php Outdated Show resolved Hide resolved
src/DefaultEnvironment.php Outdated Show resolved Hide resolved
src/DefaultEnvironment.php Outdated Show resolved Hide resolved
src/EnvironmentFlatConfigRegistryInterface.php Outdated Show resolved Hide resolved
@discordier
Copy link
Member

We discussed that we rather add an additional interface to the base config class which allows to fetch the config better.
The old interface will get deprecated in favor of the new one.

@zonky2 zonky2 modified the milestones: 2.2.0, 2.3.0 May 11, 2022
@zonky2 zonky2 changed the title Add flat mode for the tree picker [WIP] Add flat mode for the tree picker May 11, 2022
@stefanheimes stefanheimes changed the base branch from release/2.2.0 to master June 21, 2022 22:30
@stefanheimes
Copy link
Member

Change the merge from target => release/2.2.0 to master since master is the 2.2.x version.

@zonky2 zonky2 modified the milestones: 2.3.0, Future Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants