Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check getModelError to ToggleHandler #612

Open
zonky2 opened this issue Oct 14, 2023 · 0 comments
Open

Add check getModelError to ToggleHandler #612

zonky2 opened this issue Oct 14, 2023 · 0 comments
Assignees
@discordier @zonky2
Labels
enhancement
Milestone
2.4.0

Comments

@zonky2
Copy link
Contributor

zonky2 commented Oct 14, 2023

We should also add the check for getModelError to the ToggleHandler like in EditMask - and if necessary add the output of the error to the list display

EditMask

dc-general/src/Contao/View/Contao2BackendView/EditMask.php

Line 695 in e58c706

if ($this->editInformation->getModelError($this->model)) {

ToggleHandler

dc-general/src/Contao/View/Contao2BackendView/ActionHandler/ToggleHandler.php

Line 132 in e58c706

@zonky2 zonky2 added this to the 2.3.0 milestone Oct 14, 2023
@zonky2 zonky2 modified the milestones: 2.3.0, 2.3.1 Oct 31, 2023
@zonky2 zonky2 modified the milestones: 2.3.1, 2.2.3, 2.4.0 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@discordier discordier

@zonky2 zonky2

Labels
enhancement
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
2 participants
@discordier @zonky2