repo: Add missing O_CLOEXEC #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're pervasively missing this and O_CLOEXEC is IMO quite important
for anything caring about security. Rust notably does *not*
automatically close fds with `std::process::Command`.
Now...digging into this I do think we should take a dep on
cap-std{,-ext} but that's a distinct thread.
Signed-off-by: Colin Walters <[email protected]>
allisonkarlitskaya
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're pervasively missing this and O_CLOEXEC is IMO quite important for anything caring about security. Rust notably does not automatically close fds with
std::process::Command.Now...digging into this I do think we should take a dep on cap-std{,-ext} but that's a distinct thread.