Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New branch for removing gogo/protobuf #97

Open
kzys opened this issue Oct 26, 2021 · 3 comments
Open

New branch for removing gogo/protobuf #97

kzys opened this issue Oct 26, 2021 · 3 comments

Comments

@kzys
Copy link
Member

kzys commented Oct 26, 2021

I've been working on upgrading protobuf packages in containerd. Now Protobuild supports new protoc-gen-go and #96 will add new protoc-gen-go-ttrpc which should be able to generate ttrpc code that works with the new protoc-gen-go.

However, next few PRs will make some backward-incompatible changes, namely

  • Removing gogo/protobuf from ttrpc itself
  • Updating example/

Since ttrpc is used by containerd which has relatively long support policy, we would make some enhancements such as #75 and #94. So I'm reluctant to make ttrpc's main branch incompatible with gogo/protobuf right now.

Instead, could we have a branch to remove gogo/protobuf? If so, do we want to do Go-style branching (e.g. v2) instead of containerd-style (release/1.0)?

@dmcgowan
Copy link
Member

I think a release/1.0 branch is reasonable. This is what we have done in other dependent projects as well

@kzys
Copy link
Member Author

kzys commented Oct 26, 2021

Sounds good to me. Let me clean up open PRs. I'd like to merge 1.0.x enhancements before cutting the branch.

@dcantah
Copy link
Member

dcantah commented Jan 29, 2024

Should this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants