Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tekton: allow skipped tasks #1144

Merged

Conversation

MartinBasti
Copy link
Contributor

Intentionally skipped tasks shouldn't be considered as unsuccesfull in OSBS context. Allow skipped tasks in OSBS.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates

Intentionally skipped tasks shouldn't be considered as unsuccesfull in
OSBS context. Allow skipped tasks in OSBS.

Signed-off-by: Martin Basti <[email protected]>
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

status_reason in ['Succeeded', 'Completed']

Nice one Tekton

@MartinBasti MartinBasti merged commit 5413870 into containerbuildsystem:master Nov 20, 2024
19 checks passed
@MartinBasti MartinBasti deleted the dont-fail-with-skip-task branch November 20, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants