Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop subclassing Path with RequestBundleDir and SourceDir (python 3.12 fix) #993

Open
eskultety opened this issue Apr 25, 2024 · 0 comments

Comments

@eskultety
Copy link
Member

eskultety commented Apr 25, 2024

RequestBundleDir and SourcesDir both subclass Path which is now breaking because Path (since python 3.12 pathlib) operations that return a new Path (like joinpath and relative_to) are returning a new RequestBundleDir or SourcesDir instead of a new Path like the cachito code expects.

Reference: https://github.com/python/cpython/blob/2f0778675ad0eaf346924ef6a2f60529b92ffcfa/Lib/pathlib/_abc.py#L233
Found-by: @taylormadore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant