add secrets field support for ControllerGetVolume Request
#515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
reviewed
Jun 16, 2022
humblec
force-pushed
the
controller-get-volume
branch
2 times, most recently
from
f667a20
to
9b2faaa
Compare
At present secrets are not part of this request and some consumers need this field for its operation.: That said, storage backends like Ceph Cluster require the access to be achieved with the help of authentication. For such systems this becomes a requirement to have secrets/credentials be part of the request CO make for its further operations or fetching the state from the backend cluster. Signed-off-by: Humble Chirammal <[email protected]>
humblec
force-pushed
the
controller-get-volume
branch
from
9b2faaa
to
1cf046f
Compare
|
Do we also need a corresponding field in the PV? |
@xing-yang I was planning to have the PV/CO side ( implementation) details listed in Kube issue as the field and implementation require some thoughts as discussed in #371. Considering CSI spec support can be independent to the implementation of CO, thought of pulling this first. |
|
Cc @jdef |
|
I agree that we need to pass secrets down to ControllerGetVolume, but I'd prefer to do it in such a way that doesn't require COs to store ever more secrets (as I mentioned in #371). Is anyone working on a proposal to constrain secret handling? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present
secretsare not part of this request and someconsumers need this field for its operation.: That said,
storage backends like Ceph Cluster require the access to be
achieved with the help of authentication. For such systems this
becomes a requirement to have secrets/credentials be part of
the request CO make for its further operations or fetching the state
from the backend cluster.
Additional note for reviewer:
Similar request was raised for NodeGetVolumeStats() here #
#371
which was not reached into consensus. One concern raised in similar request (#371)
is the explosion of secrets field in the spec for various RPC calls.
In turn this secret field requirement becoming a request for pretty
much all the RPC calls.
Signed-off-by: Humble Chirammal [email protected]
Signed-off-by: Prasanna Kumar Kalever [email protected]