This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
FM-367: Handle snapshot offer #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
force-pushed
the
fm-367-handle-snapshot-offer
branch
from
a842cf3
to
8be9829
Compare
adlrocha
approved these changes
Nov 23, 2023
|
|
||
| // Notify the snapshotter. We don't do this in `commit` because *this* is the height at which | ||
| // this state has been officially associated with the application hash, which is something | ||
| // we will receive in `offer_snapshot` and we can compare. If we did it in `commit` we'd |
There was a problem hiding this comment.
This is done to ensure that the state_params that we are requesting belongs to the right height because in end_block we haven't yet computed the up to date state_params, right?
aakoshh
force-pushed
the
fm-361-serve-snapshot-chunks
branch
from
14ef420
to
0b82653
Compare
aakoshh
force-pushed
the
fm-367-handle-snapshot-offer
branch
from
f7f1ff4
to
c9be10d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes consensus-shipyard/ipc#174
Implement the
offer_snapshotABCI method by parsing the manifest back from the snapshot and accepting it if the application hash in it (coming from a light client) matches what the FVM state parameters in the snapshot.For now if the offer cannot be validated we return
Rejectrather thanRejectSender; it might just be a bug, rather than any bad intentions.The PR moves the notification of the manager from
committobegin_block, so that the snapshot height is associated with the block where theapp_hashwill match the snapshot content. This is so we can validate theOfferSnapshot::app_hashwhich is something CometBFT acquired for us atOfferSnapshot::heightagainst the FVM parameters in the manifest.This is a change from #389 but also reflects what I did in #420 (which is not merged into this branch).