Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox - Icon does not update correctly in some cases #95

Open
conorgil opened this issue Sep 24, 2018 · 0 comments
Open

Firefox - Icon does not update correctly in some cases #95

conorgil opened this issue Sep 24, 2018 · 0 comments
Assignees
Labels
bug Something isn't working FireFox

Comments

@conorgil
Copy link
Owner

The browser action button icon doesn't correctly update in FF and can get into a state where it shows "No 2FA" on a page that does support 2FA.

To replicate:

  1. Open github.com. The 2FAN icon will correctly show the green check mark.
  2. Click the 2FAN icon to open the menu.
  3. Click the "Show 2FA Guide" button to open the docs
  4. A separate window opens with the docs. This subdomain of Github is not in the dataset, so the icon updates to show "No 2FA"
  5. Close the docs window.
  6. The 2FAN icon in the original window now shows "No 2FA" even though the page is still on github.com

screen shot 2018-09-23 at 11 30 55 pm

Browser: Firefox 61.0.2
OS: OSX 10.13.6

@conorgil conorgil added bug Something isn't working FireFox labels Sep 24, 2018
@conorgil conorgil self-assigned this Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FireFox
Projects
None yet
Development

No branches or pull requests

1 participant