feat: remove as Error type assertions
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, errors are now consistently typed as `unknown`. BREAKING CHANGE: The types of errors have been changed from `Error` to unknown because they are not statically known (in JavaScript, _anything_ can be thrown). If you know that in a particular situation, errors can only be instances of `Error`, you can do the type assertion yourself (`error as Error`). Otherwise, you should check whether an error is actually an `Error`, for example with `error instanceof Error`. Closes connor4312#87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, errors are now consistently typed as
unknown.BREAKING CHANGE: The types of errors have been changed from
Errorto unknown because they are not statically known (in JavaScript, anything can be thrown). If you know that in a particular situation, errors can only be instances ofError, you can do the type assertion yourself (error as Error). Otherwise, you should check whether an error is actually anError, for example witherror instanceof Error.Closes #87