Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback on Infura if no injected web3 detected #7

Open
conlan opened this issue Jan 20, 2020 · 12 comments
Open

Fallback on Infura if no injected web3 detected #7

conlan opened this issue Jan 20, 2020 · 12 comments
Labels
enhancement New feature or request

Comments

@conlan
Copy link
Owner

conlan commented Jan 20, 2020

Currently there's a button "Connect to Web3" that activates the injected web3 connector.

Screen Shot 2020-01-19 at 11 56 57 PM

However in cases where no injected connector is found (ie Safari) then we should just fallback on Infura with no "Connect to Web3" button displayed. There should be a property for setting the project's Infura ID (ie mainnet.infura.io/v3/XXX).

Token annotations can be directly linked to by including an address and id parameter: https://conlan.github.io/nft-scribe/?address=0x1301566b3CB584E550A02D09562041DDC4989B91&id=124

This makes the page automatically refresh and show those details on start. Links like this should on Safari or browsers with no injected Web3 since they'll be falling back on Infura in those cases.

File here: https://github.com/conlan/nft-scribe/blob/master/client/src/index.js

@conlan conlan added the enhancement New feature or request label Jan 20, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.904 ETH (150.0 USD @ $165.93/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Jan 20, 2020

Issue Status: 1. Open 2. Cancelled


Workers have applied to start work.

These users each claimed they can complete the work by 2 weeks, 3 days from now.
Please review their action plans below:

1) eswarasai has applied to start work (Funders only: approve worker | reject worker).

Would like to tackle this and implement the fallback provider as Infura for web3 stuff
2) molecula451 has applied to start work (Funders only: approve worker | reject worker).

I am ready to take on this task
3) kryptos-ke has applied to start work (Funders only: approve worker | reject worker).

I am interested in tackling this issue at hand. Thanks
4) 18dew has applied to start work (Funders only: approve worker | reject worker).

Provide with a conditional check prior rendering the button.
5) sanchaymittal has applied to start work (Funders only: approve worker | reject worker).

Experienced with Infura and its user cases. Intrested to work on this task.
6) wisdomabioye has applied to start work (Funders only: approve worker | reject worker).

I'll fix this. Let me work on it.
7) phantomcracker has applied to start work (Funders only: approve worker | reject worker).

  • Fix "Connect to Web3" button on Safari Browser

Waiting for confirmation

Learn more on the Gitcoin Issue Details page.

@conlan conlan changed the title Hook up "Connect to Web3" button to use Infura if no injected web3 Fallback on Infura if no injected web3 detected Jan 20, 2020
@conlan
Copy link
Owner Author

conlan commented Jan 22, 2020

Hi @iamonuwa -- lemme know if you have questions about anything!

A test case for when this is working correctly is being able to visit a link like: https://conlan.github.io/nft-scribe/?address=0x1301566b3CB584E550A02D09562041DDC4989B91&id=124 and have it work on Safari or browser with no web3 injection available (since it will be falling back on Infura). Here's an image of what it looks like when I have Metamask:

Screen Shot 2020-01-21 at 11 49 46 PM

@iamonuwa
Copy link

Thanks, understood. Expect it before EOD

@conlan
Copy link
Owner Author

conlan commented Jan 24, 2020

Hey @iamonuwa just checking in if you had any questions on this one?

@iamonuwa
Copy link

Am presently working on it.

@conlan
Copy link
Owner Author

conlan commented Jan 25, 2020

Okay, cool :)

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@iamonuwa due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@iamonuwa due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled


The funding of 0.904 ETH (168.73 USD @ $186.65/ETH) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants