Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Adding example for reordering out of order messages #179

Open
1123 opened this issue Oct 17, 2018 · 9 comments
Open

Question: Adding example for reordering out of order messages #179

1123 opened this issue Oct 17, 2018 · 9 comments

Comments

@1123
Copy link
Contributor

1123 commented Oct 17, 2018

I recently came across this question: https://groups.google.com/forum/#!topic/confluent-platform/5NrqRz-GITk . Would it make sense to contribute an example stateful transformer to achieve this in this repository?

@miguno
Copy link
Contributor

miguno commented Oct 23, 2018

@1123 : If you'd like to contribute such a stateful example, then this would be great!

sshcherbakov added a commit to sshcherbakov/kafka-streams-examples that referenced this issue Nov 25, 2021
sshcherbakov added a commit to sshcherbakov/kafka-streams-examples that referenced this issue Nov 25, 2021
@sshcherbakov
Copy link

I sketched up an example for reordering using stateful transformer.
Would be glad to discuss.

@bbejeck
Copy link
Contributor

bbejeck commented Nov 29, 2021

Hi, @sshcherbakov would you consider contributing this to https://github.com/confluentinc/kafka-tutorials?
I can help you with the tutorial writing process if you want.

@mjsax
Copy link
Member

mjsax commented Dec 1, 2021

PR: #411

@sshcherbakov
Copy link

sshcherbakov commented Dec 3, 2021

Thank you @bbejeck and apologies for delay in response.
I checked with my employer and it seems that I may contribute to https://github.com/confluentinc/kafka-tutorials

Thanks @bbejeck, @mjsax for the thorough review, I'll correct. Btw. there might be an issue with the not fixed time zone. I'll try to improve that as well.

@mjsax
Copy link
Member

mjsax commented Dec 3, 2021

Should we still merge #441 or move directly to a kafka-tutorials contribution? No harm to merge, but the examples repo is superseded with the tutorial so not sure how much sense it makes to add to ti?

@bbejeck
Copy link
Contributor

bbejeck commented Dec 3, 2021

If @sshcherbakov is willing to do a tutorial then I'd say move it to a kafka-tutorials contribution. I'll leave it to @sshcherbakov if he wants to close #411.

@bbejeck
Copy link
Contributor

bbejeck commented Dec 3, 2021

@sshcherbakov if you have any questions or need any help feel free to reach out to me.

sshcherbakov added a commit to sshcherbakov/kafka-streams-examples that referenced this issue Dec 4, 2021
sshcherbakov added a commit to sshcherbakov/kafka-streams-examples that referenced this issue Dec 4, 2021
@sshcherbakov
Copy link

I hope to have addressed all comments and updated PR.
Also fixed time zone to UTC and made a couple of minor simplifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants