Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From-vscode HTTP request headers should be proxied #92

Open
jlrobins opened this issue Oct 17, 2024 · 0 comments · May be fixed by #99
Open

From-vscode HTTP request headers should be proxied #92

jlrobins opened this issue Oct 17, 2024 · 0 comments · May be fixed by #99
Assignees
Labels
enhancement New feature or request

Comments

@jlrobins
Copy link

jlrobins commented Oct 17, 2024

The proxying code for either kafka rest or schema registry needs to proxy not only the request body, but also the request headers. For example, creating schemas via the SR register route only works consistently if the content-type is set to "application/json" (read all the way through to the bottom of the issue).

I suggest that the processors work together to ultimately make a new MultiMap for the proxy request headers through a process not unlike:

  • Start with copy of the request to-be-proxied headers
  • Strip out the headers meant only for sidecar to consume (x-cluster-id , x-connection-id)
  • Add in any new headers needed (like sidecar-managed authorization auth token stuff)

So that efforts made on vscode-side to add in extra headers if / when necessary are honored.

While here, it'd also be AWESOME if there were a quarkus setting we could set when sidecar is launched that would put the proxy code into debugging mode, ala curl -v so that we can see the request URL, headers, and body plus then the response headers + body explicitly logged out.

@rhauch rhauch added this to the Schema Management milestone Oct 21, 2024
@rhauch rhauch added the enhancement New feature or request label Oct 21, 2024
@rohitsanj rohitsanj linked a pull request Oct 21, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants