Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kbs key release rework #2055

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Kbs key release rework #2055

merged 4 commits into from
Nov 22, 2024
+133 −95

Commits on Nov 22, 2024

  1. test/e2e: Update KBS key path 

    - In `NewKeyBrokerService` we create a
default secret in `reponame/workload_key/key.bin`
as the KBS needs at least one secret to start
- In `SetSampleSecretKey` we are then resetting a resource
in the same path, which causes an error
```
Set secret failed: write local fs
```
I guess as the kbs process owns that directory.
- Update the code to set a new secret for each test
and use a different path to prevent this clash

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    119fb75 View commit details
    Browse the repository at this point in the history

  2. test/e2e: azure: Refactor out TestTrusteeOperatorKeyReleaseForSpecifi… 

    …cKey

Now the `DoTestKbsKeyRelease` test can have
customised secret and resource path, we can re-use
it for the trustee test

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4838286 View commit details
    Browse the repository at this point in the history

  3. test/e2e: Test should fail if we error during set-up 

    We have had an issue where the secret key setting wasn't
working and throwing errors and we just ignored it. To help
with debugging we should be responding to errors rather than
just ignoring them.

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    212e050 View commit details
    Browse the repository at this point in the history

  4. tests/e2e: Minor tidy-up and logging 

    - Trace out the test command being run for debug
- Remove unnecessary double if check

Signed-off-by: stevenhorsman <[email protected]>
    @stevenhorsman
    stevenhorsman committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    6356d34 View commit details
    Browse the repository at this point in the history