Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking CI jobs required #2101

Open
wainersm opened this issue Oct 9, 2024 · 1 comment
Open

Marking CI jobs required #2101

wainersm opened this issue Oct 9, 2024 · 1 comment

Comments

@wainersm
Copy link
Member

wainersm commented Oct 9, 2024

This topic was raised by me on Oct 9, 2024 Peer Pods Interlock meeting: all CI jobs for pull requests are currently non-required. I suggested to make some of them required, so to avoid situation where regressions sneaked in by mistake and it can take time until one realizes and effectively fix it. Some jobs are quality-code related, for example the Go linters, and we don't want the code "degradation" over time. So on the meeting no ones was opposed to the suggestion, now the question is what jobs should be required.

As of today, the list is:

Job should be required? (y/n) Comments
Commit Message Check / Commit Message Check
build / cloud-api-adaptor (dev, ubuntu-latest)
check links / checklinks
e2e tests
build / cloud-api-adaptor (release, ubuntu-latest)
build / controllers (peerpod-ctrl) (pull_request)
lint / golangci-lint
build / volume controllers (csi-wrapper)
lint / shellcheck
build / webhook
lint / go mod tidy
lint / govulncheck
lint / Packer check
lint / Terraform check
DCO
License Compliance
Security Analysis

PLEASE LEAVE YOUR COMMENTS THAT I WILL UPDATE THE TABLE ABOVE

@wainersm
Copy link
Member Author

wainersm commented Oct 9, 2024

IMO we should make required:

  • Commit Message Check
  • all build / *
  • all lint / *
  • DCO

The e2e tests shouldn't be required because we still want to run with discretion (I guess).

Technically Security Analysis is very important but I don't know exactly whether it makes useful analysis to our project. Also don't know if the job is stable. Kind of the same for License Compliance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant