From 964599537eead20e732dd6dd8f6b1c20015a0301 Mon Sep 17 00:00:00 2001 From: stevenhorsman Date: Wed, 2 Oct 2024 14:24:30 +0100 Subject: [PATCH] podvm: Make download-image.sh always pull During some recent testing of bug fixes I spent quite a lot of time trying to understand why the fixes weren't having any effect on peer pods. After a while I found it was because although the registry version of the podvm image had been updated, when running `download-image.sh` it was just using the version I'd previously downloaded. If we pass `--pull=always`, in the container create command, this should resolve that problem and it looks to be supported on docker and podman clis Signed-off-by: stevenhorsman --- src/cloud-api-adaptor/podvm/hack/download-image.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cloud-api-adaptor/podvm/hack/download-image.sh b/src/cloud-api-adaptor/podvm/hack/download-image.sh index 1297b3415..50ceaf574 100755 --- a/src/cloud-api-adaptor/podvm/hack/download-image.sh +++ b/src/cloud-api-adaptor/podvm/hack/download-image.sh @@ -47,7 +47,7 @@ else fi # Create a non-running container to extract image -$container_binary create --platform="$platform" --name "$container_name" "$image" /bin/sh >/dev/null 2>&1; +$container_binary create --pull=always --platform="$platform" --name "$container_name" "$image" /bin/sh >/dev/null 2>&1; # Destory container after use rm-container(){ $container_binary rm -f "$container_name" >/dev/null 2>&1;