Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blogpost about v0 recipe changes #190

Merged
merged 20 commits into from
Nov 15, 2024

Conversation

kenodegard
Copy link
Contributor

Description

This adds a blog post discussing when and how to go about making changes to the v0 recipe format now that v1 has been approved and is being prototyped in rattler-build.

Copy link

netlify bot commented May 8, 2024

Deploy Preview for conda-dot-org ready!

Name Link
🔨 Latest commit 8813daa
🔍 Latest deploy log https://app.netlify.com/sites/conda-dot-org/deploys/664b96732c86c20007de5f43
😎 Deploy Preview https://deploy-preview-190--conda-dot-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kenodegard kenodegard marked this pull request as ready for review June 11, 2024 16:03
@kenodegard kenodegard requested a review from wolfv June 11, 2024 16:04
@kenodegard
Copy link
Contributor Author

@wolfv I'd greatly appreciate your input here

@wolfv
Copy link
Contributor

wolfv commented Sep 2, 2024

I generally like it a lot. Parts of it are a bit over the top and chat-botty (ie. paramount) and parts are a bit unspecific (e.g. what is the process exactly that you want to follow? Where should change requests be made? In the conda-build repo as an issue or as a CEP?).

But I think more communication is better so I would happy to see a blog post like this asap! :)

@wolfv
Copy link
Contributor

wolfv commented Sep 2, 2024

PS sorry for taking so long to add my input!

@kenodegard
Copy link
Contributor Author

kenodegard commented Sep 4, 2024

Where should change requests be made? In the conda-build repo as an issue or as a CEP?

Honestly this is where I was waiting for the steering council to tell me what they expected. For any updates to the new recipe format what do we expect to happen?

I'm under the assumption it will require a CEP and a recipe version bump. Or are these recipe format changes batched and only released as a new version after some time? Or is the recipe version only bumped if an existing key is modified/removed (i.e., adding new keys doesn't result in a bump)?

@kenodegard
Copy link
Contributor Author

Since the schema_version is defined as an integer, incrementing the version anytime a new key is added seems very noisy

@kenodegard kenodegard requested a review from a team as a code owner September 4, 2024 18:35
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for conda-dot-org ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5062b5f
🔍 Latest deploy log https://app.netlify.com/sites/conda-dot-org/deploys/67376a3a8d96a10008a70d76
😎 Deploy Preview https://deploy-preview-190--conda-dot-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

blog/news.json Outdated
],
"description": "The recent approval of the new recipe format (`recipe.yaml`, v1) does not mean the end of the old format (`meta.yaml`, v0). The conda community must balance innovation with support for legacy systems.\n",
"image": "img/blog/2024-09-04-v0-format-modifications/banner.png",
"date": "2024-05-20T00:00:00"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date here needs to be updated

@@ -1,60 +1,62 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be renamed to reflect the new publication date (vs 2024-05-20)

@jaimergp jaimergp requested a review from a team as a code owner November 14, 2024 20:24
@jaimergp
Copy link
Contributor

@kenodegard - is this good to go?

Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny punctuation suggestions

blog/2024-11-15-v0-format-modifications.mdx Outdated Show resolved Hide resolved
blog/2024-11-15-v0-format-modifications.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wolfv
Copy link
Contributor

wolfv commented Nov 15, 2024

I have two minor comments:

  • I think I would remove the OpenAI author thing as I am not sure how well that is received (but that's a personal opinion)
  • For rattler-build, I would prefer it if we say "developed in rattler-build" instead of prototyped (because we are a bit beyond the prototype stage these days as things are rolled out in conda-forge).

Otherwise nice blog post!

@kenodegard kenodegard merged commit 4df69bc into conda:main Nov 15, 2024
6 checks passed
@kenodegard kenodegard deleted the v0-modifications branch November 15, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants