Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index benchmark #5508

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Add index benchmark #5508

merged 7 commits into from
Oct 2, 2024

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Oct 1, 2024

Description

Adds a benchmark test so we can see the speed improvements with the new lazy index from conda 24.9.0.

A few things are done here:

  1. We deprecate two unused arguments (locking and timeout) from conda_buil.index.get_build_index
  2. We force the benchmark CI job to use conda=24.7 so we can get an accurate before measurement (we will revert this change in Lazy index #5488)
  3. Add benchmark test in tests/test_index.py::test_get_build_index
  4. Ignore filterwarings in pyproject.toml to avoid deprecation errors (we will revert this change in Lazy index #5488)

Xref #5488

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 1, 2024
Copy link

codspeed-hq bot commented Oct 1, 2024

CodSpeed Performance Report

Merging #5508 will not alter performance

Comparing kenodegard:index-benchmark (1f533da) with main (56e5a04)

Summary

✅ 4 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main kenodegard:index-benchmark Change
🆕 test_get_build_index N/A 1.6 s N/A

Comment on lines +1853 to +1865
if Version(conda_version) >= Version("24.9.0"):
# conda >=24.9.0
clobber_warning_found = False
for record in caplog.records:
if "ClobberWarning:" in record.message:
clobber_warning_found = True
assert clobber_warning_found
else:
# before the new lazy index added in conda 24.9.0
# see https://github.com/conda/conda/commit/1984b287548a1a526e8258802a6f1fec2a11ecc3
out, err = capfd.readouterr()
assert "ClobberWarning" in err

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix from #5488 that we need to get this merged

@kenodegard kenodegard marked this pull request as ready for review October 1, 2024 22:44
@kenodegard kenodegard requested a review from a team as a code owner October 1, 2024 22:44
@kenodegard kenodegard mentioned this pull request Oct 1, 2024
3 tasks
@jezdez jezdez merged commit 6f20ff7 into conda:main Oct 2, 2024
28 checks passed
@kenodegard kenodegard deleted the index-benchmark branch October 2, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

4 participants