Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tk pinned to 8.6.10 for python 3.8 series. Necessary? #44

Open
dsentinel opened this issue Aug 13, 2020 · 2 comments
Open

Tk pinned to 8.6.10 for python 3.8 series. Necessary? #44

dsentinel opened this issue Aug 13, 2020 · 2 comments

Comments

@dsentinel
Copy link

I'd like to use a forked tk=8.6.9 with the latest and future pythons. (reasons below)
As 8.6.x is the same minor version, ABI should match. Why is this pinned to a patch version?
I dug a bit for reasons. I can't find where this is set/changed in the recipe.

If there is a reason or incompatibility I'll bow down fast. ( or maybe suggest or PR for a variant ?)
I'm just asking to make sure this specific pin did slip in unnecessarily.

Looks like tk=8.6.9 was allowed through python=3.8.0 up to build 5 on conda-forge.

$ conda search  -i python=3.8.0 |grep -e tk -e url
...
url         : https://repo.anaconda.com/pkgs/main/osx-64/python-3.8.0-h359304d_2.conda
  - tk >=8.6.8,<8.7.0a0
...
url         : https://conda.anaconda.org/conda-forge/osx-64/python-3.8.0-hd366da7_4.tar.bz2
  - tk >=8.6.9,<8.7.0a0
url         : https://conda.anaconda.org/conda-forge/osx-64/python-3.8.0-hd366da7_5.tar.bz2
  - tk >=8.6.10,<8.7.0a0

Build got bumped to 5 in conda-forge/python-feedstock#277 but I couldn't figure out where the pin came from.

Anaconda seemed to let it go longer with tk>=8.6.8 here for python=3.8.0, and through 3.8.3.

There are a few confirmed issues on bugs.python.org re: tk=8.6.10 on macos.... If folks want to hang back on an older Tk, why not right? It's great that we have Tk as a separate package from python, but less so if it's hard pinned.

Background

I'm packaging a legacy tkinter application used on macos that, only seems to work with tk=8.6.9 compiled with x11 instead of aqua (Yeah, its a hairball).
There are others interested in the no aqua version which may get merged if I can figure out how to implement variant or whatever way you create 2 different packages with the same name & version with a different compile options. (insight welcome: #22)

This legacy app is packaged in the same env[metapackage, constructor] as other more modern software, and I'd prefer not to hold everything else back.

@isuruf
Copy link
Member

isuruf commented Aug 13, 2020

This is an issue with tk recipe having min_pin=x.x.x.x.x.x implicitly in https://github.com/conda-forge/tk-feedstock/blob/master/recipe/meta.yaml#L21. Transferring there.

@isuruf isuruf transferred this issue from conda-forge/python-feedstock Aug 13, 2020
@dsentinel
Copy link
Author

Thanks @isuruf , I didn't think to follow the run exports chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants