Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually migrate for Python 3.12 #234

Closed
leofang opened this issue Jan 4, 2024 · 18 comments · Fixed by #235
Closed

Manually migrate for Python 3.12 #234

leofang opened this issue Jan 4, 2024 · 18 comments · Fixed by #235

Comments

@leofang
Copy link
Member

leofang commented Jan 4, 2024

For some reason the bot shows errors.

@leofang
Copy link
Member Author

leofang commented Jan 4, 2024

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I started rerendering the recipe in #235.

@jakirkham
Copy link
Member

Did a little reading. FWICT it looks like the bot was unable to solve the dependencies. Relevant snippet below:

  Could not solve for environment specs
  The following package could not be installed
  └─ cusparselt 0.2.0.1.* 1 does not exist (perhaps a typo or a missing channel).

@leofang
Copy link
Member Author

leofang commented Jan 9, 2024

@jakirkham @beckermr the PY312 migration status still says cupy is not solvable, despite I manually added the migrator (#235). It's unclear to the why the bot would complain about cusparselt. I checked on anaconda.org and saw the package is still there. Any clue if this is a disguise of other issues?

@leofang leofang reopened this Jan 9, 2024
@beckermr
Copy link
Member

beckermr commented Jan 9, 2024

Could be for sure. We should add a test case to the solver test package and figure out when we have time.

@leofang
Copy link
Member Author

leofang commented Jan 9, 2024

Thanks, Matt! Any tip for how I can unblock the migration for CuPy downstream for the time being?

@jakirkham
Copy link
Member

jakirkham commented Jan 9, 2024

Not to speak for Matt, but you could mark CuPy done for the Python 3.12 migration by making a PR similar to this one ( regro/cf-graph-countyfair#7 )

@leofang
Copy link
Member Author

leofang commented Jan 11, 2024

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I started rerendering the recipe in #236.

@conda-forge-admin conda-forge-admin mentioned this issue Jan 11, 2024
1 task
@jakirkham
Copy link
Member

Maybe this is relevant ( #238 )?

@jakirkham
Copy link
Member

Unfortunately that didn't work, trying a different approach with PR ( #240 )

This was referenced Jan 19, 2024
@leofang
Copy link
Member Author

leofang commented Jan 24, 2024

I'd love to get the bot bug fixed, but it seems we're still clueless. I had to disable the cusparselt support (#244) to make the bot happy. It finally works (migration is propagated to downstream: conda-forge/cuquantum-feedstock#54). Is there anything else we should do before closing this issue?

@jakirkham
Copy link
Member

Think we should take a closer look at this list and see how we can cut that down

requirements:
build:
- {{ compiler("c") }}
- {{ compiler("cxx") }}
- {{ compiler("cuda") }}
- sysroot_{{ target_platform }} 2.17 # [linux]
- cross-python_{{ target_platform }} # [build_platform != target_platform]
- python # [build_platform != target_platform]
- cython >=0.29.22,<3 # [build_platform != target_platform]
# TODO: clean up
{% if cuda_major >= 12 %}
- cuda-driver-dev # [build_platform != target_platform and linux]
- cuda-cudart-dev # [build_platform != target_platform]
- cuda-nvrtc-dev # [build_platform != target_platform]
- cuda-nvtx-dev # [build_platform != target_platform]
- cuda-profiler-api # [build_platform != target_platform]
- libcublas-dev # [build_platform != target_platform]
- libcufft-dev # [build_platform != target_platform]
- libcurand-dev # [build_platform != target_platform]
- libcusolver-dev # [build_platform != target_platform]
- libcusparse-dev # [build_platform != target_platform]
{% endif %}
# optional dependencies for CUDA 11.2+
- cudnn ~=8.8 # [build_platform != target_platform and not (aarch64 or (ppc64le and (cuda_compiler_version or "").startswith("12")))]
- nccl ~=2.16 # [build_platform != target_platform]
- cutensor ~=2.0 # [build_platform != target_platform]

Ideally we would get that down to build tools only. Atm there's quite a few libraries in there

Am sure there is some history I'm forgetting here (perhaps issues early on in CUDA 12 that have since been fixed?), but it may be worth revisiting

@leofang
Copy link
Member Author

leofang commented Jan 24, 2024

They are needed because of CuPy's autotool-like build system, which requires executable/linkable objects native to the build environment. Nothing has changed, and redundancy has been pruned.

@jakirkham
Copy link
Member

Wanted to see what would happen (even if only to see errors)

xref: #246

@hmaarrfk
Copy link
Contributor

this can be closed correct?

@jakirkham
Copy link
Member

In terms of the feedstock being migrated for Python 3.12, yes that was done a long time ago

In terms of the bot errors, don't recall whether we were able to resolve those. We certainly tried lots of things that didn't end up working

@leofang
Copy link
Member Author

leofang commented Aug 30, 2024

Let's just close this since it is not going anywhere...

@leofang leofang closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants