Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lazy import in v13 #229

Closed
leofang opened this issue Nov 3, 2023 · 1 comment · Fixed by #241
Closed

Support lazy import in v13 #229

leofang opened this issue Nov 3, 2023 · 1 comment · Fixed by #241
Assignees

Comments

@leofang
Copy link
Member

leofang commented Nov 3, 2023

No description provided.

@leofang leofang self-assigned this Nov 3, 2023
@leofang leofang mentioned this issue Jan 18, 2024
3 tasks
@leofang
Copy link
Member Author

leofang commented Jan 23, 2024

A new cupy-core package was added with almost no dependencies, while cupy is kept for backward compat, see #241 (comment).

weiji14 added a commit to weiji14/cupy-xarray that referenced this issue Jun 19, 2024
The cupy-core package from conda-forge does not bring in CUDA dependencies and thus can be installed on CPU-only CI services. Xref conda-forge/cupy-feedstock#229
weiji14 added a commit to xarray-contrib/cupy-xarray that referenced this issue Jun 21, 2024
* Install cupy-core and xarray

The cupy-core package from conda-forge does not bring in CUDA dependencies and thus can be installed on CPU-only CI services. Xref conda-forge/cupy-feedstock#229

* Re-enable building of API page in docs/conf.py

See usage instructions in https://sphinx-autosummary-accessors.readthedocs.io/en/stable/usage.html. Also need to `import cupy_xarray` to fix `exception: no module named xarray.DataArray.cupy` error following xarray-contrib/sphinx-autosummary-accessors#107.

* Undocument Dataset.cupy.get

Fixes `AttributeError: type object 'CupyDatasetAccessor' has no attribute 'get'`

* Pip install cupy_xarray on readthedocs

* Remove numpydoc and use napolean only

* Put editable install in ci/doc.yml so no need to pip install separately

Xref https://docs.readthedocs.io/en/stable/faq.html#i-need-to-install-a-package-in-a-environment-with-pinned-versions

* Add minimal docstrings to accessor methods and attributes

Adding some docstrings to the is_cupy, as_cupy and as_numpy  methods, so that the API docs page looks like center-aligned.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant