Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the underline happening on logo #2373

Closed
wants to merge 3 commits into from

Conversation

TenzDelek
Copy link

PR Checklist:
fixes #2372

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

The current underline hover effect on github and zulip logo detracts from its visual impact and professional appearance. This issue proposes the removal of the underline to enhance these brand presentation
before:
image

after:
image

@TenzDelek TenzDelek requested a review from a team as a code owner November 16, 2024 14:55
Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 79a653f
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/6738c44ace011c00081ab105
😎 Deploy Preview https://deploy-preview-2373--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@beckermr
Copy link
Member

I still see underlines on mobile.

image

@jaimergp
Copy link
Member

The underline is intentional to account for active and hover states of the link for accessibility reasons. Also, subjectively, I don't see as unprofessional 🤔

@TenzDelek
Copy link
Author

image cc @beckermr

@TenzDelek
Copy link
Author

The underline is intentional to account for active and hover states of the link for accessibility reasons. Also, subjectively, I don't see as unprofessional 🤔

while its true that the underline is great for accessibility reason, Logos on other hand serve as a unique identifier for a brand and they are often graphical by nature. Underlining a logo may interfere with the visual integrity of the brand identity.

plus we have the hover cursor as pointer which I believe is enough to demonstrate that the icons are active

Would love to hear your thoughts this @jaimergp

Copy link
Member

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happily. Some considerations:

  • Not all users will use a mouse to navigate the website, some will use a keyboard or item-by-item-selection similar device.
  • Not everyone perceives contrast and color distance in the same way. It's generally recommended to use visual cues other than color or transparency to indicate states. That's a strong reason to keep the underlines. If not, other affordances are needed, like increasing the size on hover and then something else on active.

The key aspect is to maintain the three states visually identifiable while accounting for the diversity of perception in our potential user base. Great amount of work was put into the accessibility considerations of this design and we can't introduce regressions like this for the sole purpose of aesthetics, I'm afraid.

Sites like https://design-system.service.gov.uk/accessibility/ provide some more details of how accessibility plays a role in design, if you are interested.

@TenzDelek
Copy link
Author

Happily. Some considerations:

  • Not all users will use a mouse to navigate the website, some will use a keyboard or item-by-item-selection similar device.
  • Not everyone perceives contrast and color distance in the same way. It's generally recommended to use visual cues other than color or transparency to indicate states. That's a strong reason to keep the underlines. If not, other affordances are needed, like increasing the size on hover and then something else on active.

The key aspect is to maintain the three states visually identifiable while accounting for the diversity of perception in our potential user base. Great amount of work was put into the accessibility considerations of this design and we can't introduce regressions like this for the sole purpose of aesthetics, I'm afraid.

Sites like https://design-system.service.gov.uk/accessibility/ provide some more details of how accessibility plays a role in design, if you are interested.

thank you for your point of view, I understand that accessibility should be consider prior to design aesthetics. so after reconsidering my updates, it seems like keeping the underline would be best.
closing this pr as not planned

@TenzDelek TenzDelek closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: remove the underline happening on logo
3 participants