Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsonrpcclient dependencies #908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

beenje
Copy link
Contributor

@beenje beenje commented Nov 20, 2024

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

jsonrpcclient 4.0.0 was a complete rewrite and previous dependencies were removed but they are still in the conda recipe:

  • click dependency was removed in 4.0.0
  • apply_defaults and jsonschema were removed in 4.0.1

The click <7 is quite annoying as it prevents to install jsonrpclient with packages that require a newer version of click.

I made a MR to update the recipe: conda-forge/jsonrpcclient-feedstock#6

@conda-forge/jsonrpcclient FYI

$ python show_diff.py --subdirs noarch
================================================================================
================================================================================
noarch
noarch::jsonrpcclient-4.0.0-pyhd8ed1ab_0.tar.bz2
-    "click <7",
noarch::jsonrpcclient-4.0.1-pyhd8ed1ab_0.tar.bz2
noarch::jsonrpcclient-4.0.2-pyhd8ed1ab_0.tar.bz2
-    "apply_defaults <1",
-    "click <7",
-    "jsonschema <4",

* click dependency was removed in 4.0.0
* apply_defaults and jsonschema were removed in 4.0.1
@beenje beenje requested a review from a team as a code owner November 20, 2024 11:34
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants